OMH

1. KR ver
- Enter code button text incorrect: Current: 코드 입력 / Requirement: 쿠폰 코드 등록
- By Highest Discount Rate text incorrect: Current: 높은 할인율순 / Requirement: 할인율 높은 순
- By Expiration Date text incorrect: Current: 만료일순 / Requirement: 만료임박순
- Simple button text incorrect: Current: 간단히 / Requirement: 간단히 보기
- Details button text incorrect: Current: 자세 / Requirement: 자세히 보기
2. No coupon state
- Design: there is no White frame
- Current: Have white frame, please delete
3. Coupon card
- Fixed - Amount & % discount Text size is 24px (current 20px)
- Coupon name text size is 16px (current is 14px)
- Validity & date: text size is 14px (current is 12px)
4. By Highest disocunt rate / By expiration Date sort
- % coupon displayed incorrect (coupon with 25% discount but displayed in the last)
5. By Highest disocunt rate is set as default, but current, default is By expiration date sort & Order on Sort filter also wrong
Requirement:
By Highest disocunt rate - 1st line
By expiration Date - 2nd line
6. By expiration date sort , as confirm with Plan on team,
Please support to recheck & adjust logic in here or tell me if need to create new task for this update. Thank you
requirement: https://www.figma.com/design/Tmlbxh17VqmfuCzsbzN16q/%F0%9F%8E%AB-SB--B2C-Online-Coupon?node-id=3-115&t=89MjiGVndKicmcqa-1
7. Use coupon [General] VND 100,000 Discount to made booking > BK successful (code: K26012910030H01) but coupon still displayed on My coupon page

Done

1. KR ver
- Enter code button text incorrect: Current: 코드 입력 / Requirement: 쿠폰 코드 등록 => ok
- By Highest Discount Rate text incorrect: Current: 높은 할인율순 / Requirement: 할인율 높은 순 => ok
- By Expiration Date text incorrect: Current: 만료일순 / Requirement: 만료임박순 => ok
- Simple button text incorrect: Current: 간단히 / Requirement: 간단히 보기 => ok
- Details button text incorrect: Current: 자세 / Requirement: 자세히 보기 => ok
2. No coupon state => ok
- Design: there is no White frame
- Current: Have white frame, please delete
3. Coupon card => ok
- Fixed - Amount & % discount Text size is 24px (current 20px)
- Coupon name text size is 16px (current is 14px)
- Validity & date: text size is 14px (current is 12px)
4. By Highest disocunt rate / By expiration Date sort => ok
- % coupon displayed incorrect (coupon with 25% discount but displayed in the last)
5. By Highest disocunt rate is set as default, but current, default is By expiration date sort & Order on Sort filter also wrong => ok
Requirement:
By Highest disocunt rate - 1st line
By expiration Date - 2nd line
6. By expiration date sort , as confirm with Plan on team,
requirement: https://www.figma.com/design/Tmlbxh17VqmfuCzsbzN16q/%F0%9F%8E%AB-SB--B2C-Online-Coupon?node-id=3-115&t=89MjiGVndKicmcqa-1
=> Failed, as requirement, sort by validity first, after that if expirition date is the same, will sort by fixed amount & % discount promotion type.
BUT currently, still sort by fixed amount & % discount promotion type first
7. Use coupon [General] VND 100,000 Discount to made booking > BK successful (code: K26012910030H01) but coupon still displayed on My coupon page
BK test K26022610029H01
Coupon use: Test Expiration (Apr)
=> ok

Done

harry harry wrote in #note-22:

6. By expiration date sort , as confirm with Plan on team,
phần sort sẽ làm sau . không có trong plan update lần này nhé

noted & retest later

By expiration date sort , as confirm with Plan on team,
requirement: https://www.figma.com/design/Tmlbxh17VqmfuCzsbzN16q/%F0%9F%8E%AB-SB--B2C-Online-Coupon?node-id=3-115&t=89MjiGVndKicmcqa-1
=> Failed, as requirement, sort by validity first, after that if expirition date is the same, will sort by fixed amount & % discount promotion type.
BUT currently, still sort by fixed amount & % discount promotion type first
Please fix this case

Fixed

Tracy Truong wrote in #note-25:

By expiration date sort , as confirm with Plan on team,
requirement: https://www.figma.com/design/Tmlbxh17VqmfuCzsbzN16q/%F0%9F%8E%AB-SB--B2C-Online-Coupon?node-id=3-115&t=89MjiGVndKicmcqa-1
=> Failed, as requirement, sort by validity first, after that if expirition date is the same, will sort by fixed amount & % discount promotion type.
BUT currently, still sort by fixed amount & % discount promotion type first
Please fix this case

retested on DEV, issue is fixed