개선(improvement) #2657: [FE] Normalize display logic for Meal&Breakfast info - OMH - Redmine

Actions

Copy link

개선(improvement) #2657

closed

[FE] Normalize display logic for Meal&Breakfast info

Added by ziniy Kang 3 months ago. Updated about 2 months ago.

Status:

완료성공(Resolve)

Priority:

높음(High)

Assignee:

John Lee

Start date:

12/23/2025

Due date:

12/23/2025

% Done:

100%

Estimated time:

Part:

Build env.:

Prod

Description

1. AS-IS / TO-BE Location¶

Location	Field	AS-IS	TO-BE
My page > Invoice	Product details	`N/A`	See display logic below
My page > Voucher	Meal & Breakfast Type	`N/A`	See display logic below
Voucher (Email)	Free Breakfast / Meal Type	`None / N/A`	See display logic below

2. Display Logic (Core Logic)¶

Case 1: Both values are empty
1.Condition
- Meal = `None` or `N/A`
- Breakfast = `N/A`
2.Display
- Admin: `None`
- B2C / Email:'-'

Case 2: Only one value exists
1.Condition
- One of Meal or Breakfast has a valid value
2.Display
- Display only the valid value
- Do not display `None` or `N/A`

Case 3: Both values exist
1.Condition
- Meal has a valid value
- Breakfast has a valid value
2.Display
- Display both values

3. Notes / Constraints¶

1)Booking Detail (Admin) display remains unchanged
2)This ticket does not include:
- UI layout changes
- Hotel plan configuration changes
- Data migration
3)`None` / `N/A` are considered empty values for B2C display logic

4. QA Checkpoints¶

1)Meal = None / Breakfast = N/A
→ Admin: `None`, B2C: `-`

2)Meal = Valid / Breakfast = N/A
→ Show Meal only

3)Meal = None / Breakfast = Valid
→ Show Breakfast only

4) Meal = Valid / Breakfast = Valid
→ Show both values

Additional note: If there are any other places where Meal & Breakfast Type is displayed, please let me know.

Files

Download all files

B2C-Voucher(email).png (329 KB) B2C-Voucher(email).png		Zia Han, 12/17/2025 01:52 AM
B2C-Voucher.png (498 KB) B2C-Voucher.png		Zia Han, 12/17/2025 01:52 AM
B2C-Invoice.png (531 KB) B2C-Invoice.png		Zia Han, 12/17/2025 01:52 AM
picture751-1.png (126 KB) picture751-1.png		ziniy Kang, 12/19/2025 07:58 AM
picture490-1.png (66.3 KB) picture490-1.png	K25122410005H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-2.png (145 KB) picture490-2.png	K25122410005H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-3.png (79.2 KB) picture490-3.png	K25122410006H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-4.png (123 KB) picture490-4.png	K25122410006H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-5.png (78.1 KB) picture490-5.png	K25122410007H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-6.png (204 KB) picture490-6.png	K25122410007H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-7.png (67.9 KB) picture490-7.png	K25122410008H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-8.png (217 KB) picture490-8.png	K25122410008H01	Tracy Truong, 12/24/2025 04:00 AM
picture490-9.png (112 KB) picture490-9.png	K25122410005H01	Tracy Truong, 12/24/2025 04:00 AM
picture984-1.png (148 KB) picture984-1.png	K25122410007H01	Tracy Truong, 12/24/2025 04:02 AM
picture984-2.png (121 KB) picture984-2.png		Tracy Truong, 12/24/2025 04:02 AM
picture333-1.png (144 KB) picture333-1.png	K25122610929H01 Free Breakfast (both valid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-2.png (137 KB) picture333-2.png	K25122610929H01 Free Breakfast (both valid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-3.png (155 KB) picture333-3.png	K25122610931H01 Room Only Single Use (both invalid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-4.png (119 KB) picture333-4.png	K25122610931H01 Room Only Single Use (both invalid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-5.png (140 KB) picture333-5.png	K25122610933H01 Eco Plan (meal valid/BF invalid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-6.png (114 KB) picture333-6.png	K25122610933H01 Eco Plan (meal valid/BF invalid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-7.png (151 KB) picture333-7.png	K25122610936H01 Non Parking (meal invalid/ BF valid)	Tracy Truong, 12/26/2025 04:33 AM
picture333-8.png (120 KB) picture333-8.png	K25122610936H01 Non Parking (meal invalid/ BF valid)	Tracy Truong, 12/26/2025 04:33 AM
picture694-1.png (67.5 KB) picture694-1.png	K25122610929H01 Free Breakfast (both valid)	Tracy Truong, 12/26/2025 04:37 AM
picture694-2.png (65.6 KB) picture694-2.png	K25122610931H01 Room Only Single Use (both invalid)	Tracy Truong, 12/26/2025 04:37 AM
picture694-3.png (73.8 KB) picture694-3.png	K25122610933H01 Eco Plan (meal valid/BF invalid)	Tracy Truong, 12/26/2025 04:37 AM
picture694-4.png (76.5 KB) picture694-4.png	K25122610936H01 Non Parking (meal invalid/ BF valid)	Tracy Truong, 12/26/2025 04:37 AM
스크린샷 2025-12-30 오전 9.28.47.png (131 KB) 스크린샷 2025-12-30 오전 9.28.47.png		Zia Han, 12/30/2025 12:31 AM
picture743-1.png (105 KB) picture743-1.png	K26010611678H01 - (meal valid - BF N/A) - voucher	Tracy Truong, 01/06/2026 07:14 AM
picture743-2.png (131 KB) picture743-2.png	K26010611678H01 - (meal valid - BF N/A) - invoice	Tracy Truong, 01/06/2026 07:14 AM
picture743-3.png (75.1 KB) picture743-3.png	K26010611678H01 - (meal valid - BF N/A) - email	Tracy Truong, 01/06/2026 07:14 AM
picture743-4.png (133 KB) picture743-4.png	K26010611676H01 - (both valid) - invoice	Tracy Truong, 01/06/2026 07:14 AM
picture743-5.png (105 KB) picture743-5.png	K26010611676H01 - (both valid) - voucher	Tracy Truong, 01/06/2026 07:14 AM
picture743-6.png (71.4 KB) picture743-6.png	K26010611676H01 - (both valid) - email	Tracy Truong, 01/06/2026 07:14 AM
picture743-7.png (132 KB) picture743-7.png	K26010611669H01 - (both invalid) - invoice	Tracy Truong, 01/06/2026 07:14 AM
picture743-8.png (104 KB) picture743-8.png	K26010611669H01 - (both invalid) - voucher	Tracy Truong, 01/06/2026 07:14 AM
picture743-9.png (70.5 KB) picture743-9.png	K26010611669H01 - (both invalid) - email	Tracy Truong, 01/06/2026 07:14 AM
picture054-1.png (105 KB) picture054-1.png	K26010611663H01 - (meal N/A - BF valid) - voucher	Tracy Truong, 01/06/2026 07:15 AM
picture054-2.png (70.1 KB) picture054-2.png	K26010611663H01 - (meal N/A - BF valid) - email	Tracy Truong, 01/06/2026 07:15 AM

Related issues

Actions

Copy link

Updated by ziniy Kang 3 months ago

Copied from 개선(improvement) #2654: [Plan] Normalize display logic for Meal&Breakfast info added

Actions

Copy link

Updated by ziniy Kang 3 months ago

Related to 개선(improvement) #2656: [FE] Normalize display logic for Meal&Breakfast info added

Actions

Copy link

Updated by ziniy Kang 3 months ago

Due date deleted (~~12/17/2025~~)

Actions

Copy link

Updated by Joseph Vo 3 months ago

Assignee changed from Joseph Vo to John Lee

Actions

Copy link

Updated by ziniy Kang 3 months ago

File picture751-1.png picture751-1.png added

1. Sửa text trên admin: Meal Type / Free Breakfast
2. Thứ tự hiển thị đồng nhất theo Meal Type / Free Breakfast (ở alice và các template yêu cầu)

Actions

Copy link

Updated by John Lee 3 months ago

Status changed from 신규(New) to 진행(Doing)

Actions

Copy link

Updated by John Lee 3 months ago

Status changed from 진행(Doing) to QA test
Assignee changed from John Lee to Tracy Truong
% Done changed from 0 to 100
Build env. set to Dev

Please help me check on dev

Actions

Copy link

Updated by ziniy Kang 3 months ago

Due date set to 12/23/2025
Priority changed from 보통(Normal) to 높음(High)
Start date set to 12/23/2025

Actions

Copy link

Updated by Tracy Truong 3 months ago

File picture490-1.png picture490-1.png added
File picture490-2.png picture490-2.png added
File picture490-3.png picture490-3.png added
File picture490-4.png picture490-4.png added
File picture490-5.png picture490-5.png added
File picture490-6.png picture490-6.png added
File picture490-7.png picture490-7.png added
File picture490-8.png picture490-8.png added
File picture490-9.png picture490-9.png added

Checked on OMH DEV & Email template, Invoice. Voucher on B2C
K25122410005H01 - (Meal N/A - BF Valid)
K25122410006H01 - (Meal Valid - BF N/A)
K25122410007H01 - (Meal & BF N/A)
K25122410008H01 - (Meal & BF valid)

Actions

Copy link

#10

Updated by Tracy Truong 3 months ago

File picture984-1.png picture984-1.png added
File picture984-2.png picture984-2.png added
Status changed from QA test to 완료(Done)
Assignee changed from Tracy Truong to John Lee

Actions

Copy link

#11

Updated by John Lee 2 months ago

Status changed from 완료(Done) to QA test
Assignee changed from John Lee to Tracy Truong
Build env. changed from Dev to Staging

Please help me check on staging

Actions

Copy link

#12

Updated by Tracy Truong 2 months ago

File picture333-1.png picture333-1.png added
File picture333-2.png picture333-2.png added
File picture333-3.png picture333-3.png added
File picture333-4.png picture333-4.png added
File picture333-5.png picture333-5.png added
File picture333-6.png picture333-6.png added
File picture333-7.png picture333-7.png added
File picture333-8.png picture333-8.png added

K25122610929H01 Free Breakfast (both valid)
K25122610931H01 Room Only Single Use (both invalid)
K25122610933H01 Eco Plan (meal valid/BF invalid)
K25122610936H01 Non Parking (meal invalid/ BF valid)
Tested Voucher/Invoice on STG (OMH)

Actions

Copy link

#13

Updated by Tracy Truong 2 months ago

File picture694-1.png picture694-1.png added
File picture694-2.png picture694-2.png added
File picture694-3.png picture694-3.png added
File picture694-4.png picture694-4.png added
Status changed from QA test to 완료(Done)
Assignee changed from Tracy Truong to John Lee

Actions

Copy link

#14

Updated by ziniy Kang 2 months ago

Status changed from 완료(Done) to QA test
Assignee changed from John Lee to Zia Han

Actions

Copy link

#15

Updated by Zia Han 2 months ago

Status changed from QA test to 확인(Confirmed)
Assignee changed from Zia Han to John Lee

Actions

Copy link

#16

Updated by Zia Han 2 months ago

Status changed from 확인(Confirmed) to 완료실패(Failed)

I received a request to change the text in the Invoice and Voucher sections that were previously displayed as “-” to “Room Only.”

- Condition: When both Meal and Breakfast are None or N/A.

Please apply the following:

- Invoice and Voucher should be unified to display “Room Only” for both B2C and B2B.

Actions

Copy link

#17

Updated by Zia Han 2 months ago

File 스크린샷 2025-12-30 오전 9.28.47.png 스크린샷 2025-12-30 오전 9.28.47.png added

Please refer to the table image. All conditions remain the same except for the Admin Booking Detail.
For AS-IS, I included only the values I could verify, as the exact requirements were unclear at the time—please treat it as reference only.
Kindly implement based on the TO-BE.
Thank you.

Actions

Copy link

#18