결함(Bug) #112: Remove @ohmyhotel.com in customer voucher - OMH - Redmine

Actions

Copy link

결함(Bug) #112

closed

Remove @ohmyhotel.com in customer voucher

Added by ziniy Kang 10 months ago. Updated 9 months ago.

Status:

완료성공(Resolve)

Priority:

보통(Normal)

Assignee:

Tracy Tran

Start date:

05/05/2025

Due date:

05/23/2025

% Done:

100%

Estimated time:

4.00 h

Spent time:

4.00 h

Part:

Build env.:

Prod

Description

Notion: https://www.notion.so/traport/Issue-Remove-ohmyhotel-com-in-customer-voucher-1b293412093e809a9ef5c654dffa075f

Request :
Remove @ohmyhotel.com in customer voucher
Some channels use it as confirmation number for their customer, so just need number (our booking reference or HCN or cms's confirmation number...)

Files

Download all files

picture544-1.png (465 KB) picture544-1.png		ziniy Kang, 04/29/2025 06:43 AM
image.png (124 KB) image.png		Mon Nguyen, 05/15/2025 04:25 AM
picture652-1.png (37.4 KB) picture652-1.png		ziniy Kang, 05/19/2025 08:20 AM
picture652-2.png (57.7 KB) picture652-2.png		ziniy Kang, 05/19/2025 08:20 AM
picture998-1.png (72.9 KB) picture998-1.png		ziniy Kang, 05/27/2025 02:23 AM
image.png (285 KB) image.png		Tracy Tran, 06/05/2025 09:18 AM

Actions

Copy link

Updated by ziniy Kang 10 months ago

Target version set to 4

Actions

Copy link

Updated by Mon Nguyen 10 months ago

Due date changed from 04/08/2025 to 05/05/2025
Status changed from 신규(New) to 진행(Doing)
Start date set to 05/05/2025
Estimated time set to 4.00 h
Part set to BE
Build env. set to Dev

Finish update code to remove the test @ohmyhotel.com on template
Becus just see on Prod so we can't test on outside that env, and already PR all both 3 env (dev, staging, prod)

Actions

Copy link

Updated by Mon Nguyen 10 months ago

Status changed from 진행(Doing) to 완료(Done)

Actions

Copy link

Updated by Mon Nguyen 10 months ago

Build env. changed from Dev to Staging

Applied on STG env

Actions

Copy link

Updated by Mon Nguyen 10 months ago

File image.png image.png added

Already clear text '@ohmyhotel.com'

Actions

Copy link

Updated by Mon Nguyen 10 months ago

Mon Nguyen wrote in #note-5:

Already clear text '@ohmyhotel.com' on Staging env

Actions

Copy link

Updated by Mon Nguyen 10 months ago

Assignee changed from Mon Nguyen to ziniy Kang

Dear Zin,
Please help me verify this case
Already have new booking K25051411562H01 adapt on Staging env
Thank you so much

Actions

Copy link

Updated by ziniy Kang 10 months ago

File picture652-1.png picture652-1.png added
File picture652-2.png picture652-2.png added

GBO test:
vẫn hiển thị đuôi email trên STG.

Actions

Copy link

Updated by ziniy Kang 10 months ago

Assignee changed from ziniy Kang to Mon Nguyen

Actions

Copy link

#10

Updated by Mon Nguyen 10 months ago

ziniy Kang wrote in #note-8:

GBO test:
vẫn hiển thị đuôi email trên STG.

Dear Ziniy,
The code are reverted before you start test booking, I will re-apply it again on STG
I will notify to you after applied on env
Thank you

Actions

Copy link

#11

Updated by Mon Nguyen 10 months ago

Due date changed from 05/05/2025 to 05/23/2025
Assignee changed from Mon Nguyen to ziniy Kang

Dear ziniy Kang,
Please help me check new booking again one more time on STG environment
Thank you

Actions

Copy link

#12

Updated by ziniy Kang 10 months ago

File picture998-1.png picture998-1.png added
Assignee changed from ziniy Kang to Mon Nguyen

STG:
Issue related to removing "@ohmyhotel.com" from customer vouchers
Previously, "@ohmyhotel.com" was appended to the Confirm No. in the voucher. We conducted STG tests for the two hotels below, and confirmed that @ohmyhotel.com has been removed in both cases:
K25052710756H01 / Zentis Osaka
K25052710765H01 / Hotel Monterey Fukuoka

Actions

Copy link

#13

Updated by Mon Nguyen 10 months ago

ziniy Kang wrote in #note-12:

STG:
Issue related to removing "@ohmyhotel.com" from customer vouchers
Previously, "@ohmyhotel.com" was appended to the Confirm No. in the voucher. We conducted STG tests for the two hotels below, and confirmed that @ohmyhotel.com has been removed in both cases:
K25052710756H01 / Zentis Osaka
K25052710765H01 / Hotel Monterey Fukuoka

Thanks, start PR master

Actions

Copy link

#14